Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run JavaScript tests also with node/puppeteer #17432

Merged
merged 4 commits into from Apr 11, 2021
Merged

Run JavaScript tests also with node/puppeteer #17432

merged 4 commits into from Apr 11, 2021

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Apr 7, 2021 •
edited

Description:

The PR also includes some changes to JS tests, so they don't fail in a browser that supports sendBeacon

requires matomo-org/travis-scripts#68

fixes #17424

Before merging this on, the travis-scripts PR needs to be merged and the submodule reference in this PR needs an update.

Review

  • Functional review done
  • Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done see checklist
  • Code review done
  • Tests were added if useful/possible
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed

@sgiehl sgiehl added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels Apr 7, 2021
@tsteur
Copy link
Member

tsteur commented Apr 7, 2021

@sgiehl I'm almost thinking maybe we don't want this just yet as it may be more valuable to know that the tracking works in older browsers and then most likely it also works in newer browsers. Vs if we run it in a newer browser it's harder to ensure it works in an older browser. We may not want this change just yet maybe.

@Findus23
Copy link
Member

Findus23 commented Apr 7, 2021

I think the Javascript test is one of the fastest (taking just a few minutes). So maybe it might be possible to run both.

@diosmosis
Copy link
Member

Just saw this after looking at the travis-scripts PR. I can revert the merge I did if needed.

@sgiehl
Copy link
Member Author

sgiehl commented Apr 8, 2021

running both sounds fair enough. should be simple to do that. will update this PR

@sgiehl sgiehl force-pushed the jstestsonnode branch 2 times, most recently from 360c202 to fe99f5a Compare April 8, 2021 08:17
@sgiehl sgiehl changed the title Run JavaScript tests with node/puppeteer instead of phantomjs Run JavaScript tests also with node/puppeteer Apr 8, 2021
@sgiehl
Copy link
Member Author

sgiehl commented Apr 8, 2021

Updated the PR so the travis job should first run the tests on node and afterwards on phantomjs

@diosmosis diosmosis merged commit 4850fae into 4.x-dev Apr 11, 2021
@diosmosis diosmosis deleted the jstestsonnode branch April 11, 2021 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Run Javascript tests with node/puppeteer as well as Phantomjs
4 participants
@sgiehl @tsteur @Findus23 @diosmosis