@Findus23 opened this Pull Request on April 7th 2021 Member

suggested in https://forum.matomo.org/t/how-to-ignore-system-integrity-warnings/41368

I'm not entirely sure if this is useful to a lot of people and if this is the best way to implement it, but it seemed like a nice thing for people to be able to ignore specific warnings in their setup and not having to ignore them (and potentially miss others).

Review

  • [ ] Functional review done
  • [ ] Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
  • [ ] Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • [ ] Security review done see checklist
  • [ ] Code review done
  • [ ] Tests were added if useful/possible
  • [ ] Reviewed for breaking changes
  • [ ] Developer changelog updated if needed
  • [ ] Documentation added if needed
  • [ ] Existing documentation updated if needed
@sgiehl commented on April 7th 2021 Member

@Findus23 that should already be possible by having a config.php like

<?php

return [
    'diagnostics.disabled' => DI\add(['Piwik\Plugins\Diagnostics\Diagnostic\CronArchivingCheck'])
];
@Findus23 commented on April 7th 2021 Member

@sgiehl Many thanks for the info, I totally missed that. This indeed makes this change useless and is also more elegant.

@Findus23 commented on April 7th 2021 Member

How would someone do this without creating a custom plugin?
Can one place a config.php directly into the config directory? It doesn't seem to work for me.

Maybe this could be documented in a very short page on developer.matomo.org

@sgiehl commented on April 7th 2021 Member

Haven't tested it. but it should work in a config.php in the config directory 🤔

@sgiehl commented on April 7th 2021 Member

Seems it needs to be defined this way:

<?php

return [
    'diagnostics.disabled' => DI\add([DI\get('Piwik\Plugins\Diagnostics\Diagnostic\CronArchivingCheck')])
];
@Findus23 commented on April 7th 2021 Member

This works :+1:

This Pull Request was closed on April 7th 2021
Powered by GitHub Issue Mirror