Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow skipping system check entries #17430

Closed
wants to merge 1 commit into from
Closed

Conversation

Findus23
Copy link
Member

@Findus23 Findus23 commented Apr 7, 2021

suggested in https://forum.matomo.org/t/how-to-ignore-system-integrity-warnings/41368

I'm not entirely sure if this is useful to a lot of people and if this is the best way to implement it, but it seemed like a nice thing for people to be able to ignore specific warnings in their setup and not having to ignore them (and potentially miss others).

Review

  • Functional review done
  • Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done see checklist
  • Code review done
  • Tests were added if useful/possible
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed

@Findus23 Findus23 added the Needs Review PRs that need a code review label Apr 7, 2021
@sgiehl
Copy link
Member

sgiehl commented Apr 7, 2021

@Findus23 that should already be possible by having a config.php like

<?php

return [
    'diagnostics.disabled' => DI\add(['Piwik\Plugins\Diagnostics\Diagnostic\CronArchivingCheck'])
];

@Findus23
Copy link
Member Author

Findus23 commented Apr 7, 2021

@sgiehl Many thanks for the info, I totally missed that. This indeed makes this change useless and is also more elegant.

@Findus23 Findus23 closed this Apr 7, 2021
@Findus23
Copy link
Member Author

Findus23 commented Apr 7, 2021

How would someone do this without creating a custom plugin?
Can one place a config.php directly into the config directory? It doesn't seem to work for me.

Maybe this could be documented in a very short page on developer.matomo.org

@sgiehl
Copy link
Member

sgiehl commented Apr 7, 2021

Haven't tested it. but it should work in a config.php in the config directory 🤔

@sgiehl
Copy link
Member

sgiehl commented Apr 7, 2021

Seems it needs to be defined this way:

<?php

return [
    'diagnostics.disabled' => DI\add([DI\get('Piwik\Plugins\Diagnostics\Diagnostic\CronArchivingCheck')])
];

@Findus23
Copy link
Member Author

Findus23 commented Apr 7, 2021

This works 👍

@MatomoForumNotifications

This pull request has been mentioned on Matomo forums. There might be relevant details there:

https://forum.matomo.org/t/how-can-i-disable-these-alerts/53210/3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants