@sgiehl opened this Pull Request on April 6th 2021 Member

Description:

before it was displayed as France. But as the Geo IP providers actually are not detecting it as region of France but as country instead, it makes more sense to display it that way...

fixes #5056

Review

  • [ ] Functional review done
  • [ ] Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
  • [ ] Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • [ ] Security review done see checklist
  • [ ] Code review done
  • [ ] Tests were added if useful/possible
  • [ ] Reviewed for breaking changes
  • [ ] Developer changelog updated if needed
  • [ ] Documentation added if needed
  • [ ] Existing documentation updated if needed
@sgiehl commented on April 7th 2021 Member

Can we do something with that?

We have the "problem" for various smaller countries, as the maps are missing there. See #321

This Pull Request was closed on April 7th 2021
Powered by GitHub Issue Mirror