Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display French Guiana as separate country on map #17426

Merged
merged 1 commit into from Apr 7, 2021
Merged

Display French Guiana as separate country on map #17426

merged 1 commit into from Apr 7, 2021

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Apr 6, 2021

Description:

before it was displayed as France. But as the Geo IP providers actually are not detecting it as region of France but as country instead, it makes more sense to display it that way...

fixes #5056

Review

  • Functional review done
  • Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done see checklist
  • Code review done
  • Tests were added if useful/possible
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed

@sgiehl sgiehl added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels Apr 6, 2021
@sgiehl sgiehl added this to the 4.3.0 milestone Apr 6, 2021
flamisz
flamisz reviewed Apr 6, 2021
View reviewed changes
Copy link
Contributor

@flamisz flamisz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, when I'm clicking on the country to zoom in, the deepest zoom only shows an empty image instead of the region map of the country. Previously it zoomed to France.
Can we do something with that?

@flamisz flamisz removed the Needs Review PRs that need a code review label Apr 6, 2021
@sgiehl
Copy link
Member Author

sgiehl commented Apr 7, 2021

Can we do something with that?

We have the "problem" for various smaller countries, as the maps are missing there. See #321

@sgiehl sgiehl merged commit 54336d2 into 4.x-dev Apr 7, 2021
@sgiehl sgiehl deleted the fixmap branch April 7, 2021 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flamisz flamisz flamisz left review comments

Assignees
No one assigned
Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
4.3.0
Development

Successfully merging this pull request may close these issues.

French Guiana shows up as France in maps and reports
2 participants
@sgiehl @flamisz