Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with reports disappearing from UI #17425

Conversation

nelhefni
Copy link

@nelhefni nelhefni commented Apr 6, 2021

Description:

Experimental fix for #17428
Some daily reports disappear from the UI, even though delete_reports_enable is set to 0

Review

  • Functional review done
  • Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done see checklist
  • Code review done
  • Tests were added if useful/possible
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed

@diosmosis
Copy link
Member

Hi @nelhefni, thanks for the PR! Can you please provide a description for the bug you are fixing + steps to reproduce it, or a test that shows what the change is meant to fix?

@nelhefni
Copy link
Author

nelhefni commented Apr 7, 2021

@diosmosis here is the explanation of the issue: #17428

@github-actions
Copy link
Contributor

github-actions bot commented Jun 4, 2021

This PR was last updated more than one month ago, maybe it's time to close it. Please check if there is anything we still can do or close this PR. ping @tsteur @sgiehl @diosmosis @flamisz

@github-actions github-actions bot added the Stale for long The label used by the Close Stale Issues action label Jun 4, 2021
@diosmosis
Copy link
Member

The several PRs created for the connected issue should have solved this in 4.3, so going to close this one.

@diosmosis diosmosis closed this Jun 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Stale for long The label used by the Close Stale Issues action
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants