@nelhefni opened this Pull Request on April 6th 2021 First_time_contributor

Description:

Experimental fix for https://github.com/matomo-org/matomo/issues/17428
Some daily reports disappear from the UI, even though delete_reports_enable is set to 0

Review

  • [ ] Functional review done
  • [ ] Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
  • [ ] Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • [ ] Security review done see checklist
  • [ ] Code review done
  • [ ] Tests were added if useful/possible
  • [ ] Reviewed for breaking changes
  • [ ] Developer changelog updated if needed
  • [ ] Documentation added if needed
  • [ ] Existing documentation updated if needed
@diosmosis commented on April 6th 2021 Member

Hi @nelhefni, thanks for the PR! Can you please provide a description for the bug you are fixing + steps to reproduce it, or a test that shows what the change is meant to fix?

@nelhefni commented on April 7th 2021

@diosmosis here is the explanation of the issue: https://github.com/matomo-org/matomo/issues/17428

Powered by GitHub Issue Mirror