Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run Javascript tests with node/puppeteer as well as Phantomjs #17424

Closed
Findus23 opened this issue Apr 5, 2021 · 0 comments · Fixed by #17432
Closed

Run Javascript tests with node/puppeteer as well as Phantomjs #17424

Findus23 opened this issue Apr 5, 2021 · 0 comments · Fixed by #17432
Assignees
@sgiehl
Labels
c: Tests & QA For issues related to automated tests or making it easier to QA & test issues. Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.

Comments

@Findus23
Copy link
Member

Findus23 commented Apr 5, 2021

followup to #14421

It seems like the JS tests are still using Phantomjs (which isn't maintained anymore).

https://github.com/matomo-org/travis-scripts/blob/e955829a58a5a6af00a40737c663ede98eef5dcb/travis.sh#L28-L33

It might be useful to also use Chromium/Pupeteer there to make sure Matomo JS still works in modern browsers.
@Findus23 Findus23 added Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change. c: Tests & QA For issues related to automated tests or making it easier to QA & test issues. labels Apr 5, 2021
This was referenced Apr 7, 2021
Merged
Merged
@sgiehl sgiehl self-assigned this Apr 8, 2021
@mattab mattab changed the title Run Javascript tests with Chromium instad of Phantomjs Run Javascript tests with node/puppeteer as well as Phantomjs May 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sgiehl sgiehl

Labels
c: Tests & QA For issues related to automated tests or making it easier to QA & test issues. Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Run JavaScript tests also with node/puppeteer matomo-org/matomo
2 participants
@sgiehl @Findus23