Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't load review logos if they are not shown #17422

Closed
Findus23 opened this issue Apr 4, 2021 · 2 comments · Fixed by #17446
Closed

Don't load review logos if they are not shown #17422

Findus23 opened this issue Apr 4, 2021 · 2 comments · Fixed by #17446
Labels
c: Performance For when we could improve the performance / speed of Matomo.
Milestone
4.3.0

Comments

@Findus23
Copy link
Member

Findus23 commented Apr 4, 2021

It seems like the images used by the review plugin (e.g. /plugins/Feedback/images/saasworthy.png) are loaded on every Matomo page view, even if the popup is not shown.

Changing <img src=""> to <img ng-src=""> doesn't seem to change a thing.
This could be used to save five requests that could instead load images that are blocking the rendering of the page.
@Findus23 Findus23 added c: Performance For when we could improve the performance / speed of Matomo. Help wanted Beginner friendly issues or issues where we'd highly appreciate community's help and involvement. labels Apr 4, 2021
@Findus23 Findus23 added this to the Backlog (Help wanted) milestone Apr 4, 2021
@sgiehl
Copy link
Member

sgiehl commented Apr 6, 2021

@Findus23 Did you try if a loading="lazy" attribute would do the trick?

@Findus23
Copy link
Member Author

Findus23 commented Apr 6, 2021 •
edited

@sgiehl I didn't think of that and it does indeed seem to work.
While this doesn't work in the 30% of browsers that don't support native lazy-loading yet, I guess this is a workaround unless someone knows an angular-related trick.

@Findus23 Findus23 removed the Help wanted Beginner friendly issues or issues where we'd highly appreciate community's help and involvement. label Apr 12, 2021
@Findus23 Findus23 mentioned this issue Apr 12, 2021
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: Performance For when we could improve the performance / speed of Matomo.
Projects
None yet
Milestone
4.3.0
Development

Successfully merging a pull request may close this issue.

Dont load unneeded images matomo-org/matomo
3 participants
@diosmosis @sgiehl @Findus23