@Findus23 opened this Pull Request on April 3rd 2021 Member

While the new copyable system check output is really nice, it also takes up a lot of space in Github issues (e.g. https://github.com/matomo-org/matomo/issues/17420). (same on the forum)

I try to change three things to make the reports more readable when interpreted as Markdown (as on Github and the forum).

  • smaller headings (as otherwise they use a lot of space)
  • put output into a separate line (this way it isn't also formatted as the heading)
  • wrap everything in a <details> (this way one doesn't have to scroll past everything when looking at a Github issue)

Review

  • [ ] Functional review done
  • [ ] Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
  • [ ] Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • [ ] Security review done see checklist
  • [ ] Code review done
  • [ ] Tests were added if useful/possible
  • [ ] Reviewed for breaking changes
  • [ ] Developer changelog updated if needed
  • [ ] Documentation added if needed
  • [ ] Existing documentation updated if needed
@diosmosis commented on April 5th 2021 Member

For reference, this is what it looks like after the changes:

Click to view System Check ### Mandatory checks #### PHP version >= 7.2.5: ✔ 7.4.16 #### PDO extension: ✔ #### PDO\MYSQL extension: ✔ #### MYSQLI extension: ✔ #### Other required extensions: ✔ zlib ✔ SPL ✔ iconv ✔ json ✔ mbstring ✔ Reflection ✔ filter ✔ hash ✔ session #### Required functions: ✔ debug_backtrace ✔ eval ✔ hash ✔ gzcompress ✔ gzuncompress ✔ pack #### Required PHP configuration (php.ini): ✔ session.auto_start = 0 ✔ max_execution_time = 0 OR >= 30 #### Directories with write access: ✔ $DOC_ROOT/tmp ✔ $DOC_ROOT/tmp/assets ✔ $DOC_ROOT/tmp/cache ✔ $DOC_ROOT/tmp/climulti ✔ $DOC_ROOT/tmp/latest ✔ $DOC_ROOT/tmp/logs ✔ $DOC_ROOT/tmp/sessions ✔ $DOC_ROOT/tmp/tcpdf ✔ $DOC_ROOT/tmp/templates_c #### Directories with write access for Tag Manager: ✔ $DOC_ROOT/js #### Other required extensions: ✔ openssl ### Optional checks #### File integrity: ⚠ Warning: (Disabled in development mode) #### Tracker status: ✔ #### Memory limit: ✔ 2048M #### Time zone: ✔ #### Open URL: ✔ curl #### PageSpeed disabled: ✔ #### GD > 2.x + Freetype (graphics): ✔ #### Other extensions: ✔ json ✔ libxml ✔ dom ✔ SimpleXML ✔ openssl #### Other functions: ✔ shell_exec ✔ set_time_limit ✔ mail ✔ parse_ini_file ✔ glob ✔ gzopen ✔ md5_file #### Filesystem: ✔ #### Setup Cron - Managing processes via CLI: ✔ Ok #### Last Successful Archiving Completion: ⚠ Error: Archiving last ran successfully on Tuesday, March 23, 2021 02:12:29 which is 13 days 19:08:41 ago.

Please check that you have setup a crontab calling the core:archive console command, and that you have configured a MAILTO to receive errors by email if archiving fails. You can also try to run the console command to archive your reports manually: $DOC_ROOT/console --matomo-domain=localhost core:archive. Learn more. #### Database abilities: ✔ UTF8mb4 charset ✔ LOAD DATA INFILE ✔ CREATE TEMPORARY TABLES ✔ Changing transaction isolation level #### Max Packet Size: ⚠ Warning: It is recommended to configure a 'max_allowed_packet' size in your MySQL database of at least 64MB. Configured is currently 16MB. #### Forced SSL Connection: ⚠ Warning: We recommend using Matomo over secure SSL connections only. To prevent insecure access over http, add force_ssl = 1 to the General section in your Matomo config/config.ini.php file.

Attention: Doing this without having set up a SSL certificate for using HTTPS will break Matomo. #### Geolocation: ✔ #### Update over HTTPS: ✔ #### Writable JavaScript Tracker ("/matomo.js"): ✔ #### [GoogleAnalyticsImporter] Required PHP Functions: ✔ #### [GoogleAnalyticsImporter] Required Executables (php): ✔ #### [GoogleAnalyticsImporter] Required Executables (nohup): ✔ #### Heatmap & Session Recording Tracking: ✔ '$MATOMO_URLplugins/HeatmapSessionRecording/configs.php' is accessible ### Informational results #### Matomo Version: 4.3.0-b2 #### Matomo Update History: 4.3.0-b2,4.0.0,4.2.1, #### Matomo Install Version: 4.2.1 #### Latest Available Version: 4.2.1 #### Is Git Deployment: 1 #### PHP_OS: Linux #### PHP_BINARY: /.phpbrew/php/php-7.4.16/sbin/php-fpm #### PHP SAPI: fpm-fcgi #### Timezone Version: 2021.1 #### PHP Timezone: UTC #### PHP Time: 1617657670 #### PHP Datetime: 2021-04-05 21:21:10 #### PHP INI max_execution_time: 30 #### PHP INI post_max_size: 8M #### PHP INI max_input_vars: 1000 #### PHP INI zlib.output_compression: #### Curl Version: 7.68.0, OpenSSL/1.1.1f #### Suhosin Installed: 0 #### DB Prefix: matomo_ #### DB Charset: utf8mb4 #### DB Adapter: PDO\MYSQL #### MySQL Version: 10.5.9-MariaDB-1:10.5.9+maria~focal #### Num Tables: 240 #### Browser Segment Archiving Enabled: 1 #### Development Mode Enabled: 1 #### Internet Enabled: 1 #### Multi Server Environment: 0 #### Auto Update Enabled: 1 #### Custom User Path: 0 #### Custom Include Path: 0 #### Release Channel: latest_stable #### Plugins Activated: API, AbTesting 4.1.0, Actions, ActivityLog 4.0.2, Annotations, Bandwidth 4.0.1, BulkTracking, Cohorts 4.0.3, Contents, CoreAdminHome, CoreConsole, CoreHome, CorePluginsAdmin, CoreUpdater, CoreVisualizations, CustomAlerts 4.0.1, CustomDimensions, CustomJsTracker, CustomReports 4.0.5, CustomVariables, Dashboard, DeviceDetectorCache 4.2.2, DevicePlugins, DevicesDetection, Diagnostics, Ecommerce, Events, Feedback, FormAnalytics 4.0.4, Funnels 4.0.6, GeoIp2, Goals, GoogleAnalyticsImporter 4.1.2, Heartbeat, HeatmapSessionRecording 4.0.10, ImageGraph, Insights, Installation, Intl, IntranetMeasurable, InvalidateReports 4.0.1, LanguagesManager, Live, LoginLdap 4.3.0, LoginSaml 4.0.3, MarketingCampaignsReporting 4.0.4, Marketplace, MediaAnalytics 4.0.5, MobileMessaging, Monolog, Morpheus, MultiChannelConversionAttribution 4.0.5, MultiSites, Overlay, PagePerformance, PrivacyManager, Proxy, QueuedTracking 4.0.2, Referrers, Resolution, RollUpReporting 4.0.2, RssWidget, SEO, ScheduledReports, SearchEngineKeywordsPerformance 4.2.2, SegmentEditor, SitesManager, TagManager, TestRunner, Tour, Transitions, TreemapVisualization 4.0.1, TwoFactorAuth, UserCountry, UserCountryMap, UserId, UserLanguage, UsersFlow 4.0.3, UsersManager, VisitFrequency, VisitTime, VisitorGenerator 4.0.3, VisitorInterest, VisitsSummary, WebsiteMeasurable, WhiteLabel 4.0.2, Widgetize, WooCommerceAnalytics 4.0.5 #### Plugins Deactivated: AnonymousPiwikUsageMeasurement 4.0.1, DBStats, ExampleAPI, ExampleCommand, ExampleLogTables, ExamplePlugin, ExampleReport, ExampleSettingsPlugin, ExampleTheme, ExampleTracker, ExampleUI, ExampleVisualization, LogViewer 4.0.1, Login, MobileAppMeasurable, ProfessionalServices, Provider, SecurityInfo 4.0.2, TasksTimetable 4.0.2, TrackingSpamPrevention 4.0.0 #### Plugins Invalid: #### Server Info: Apache/2.4.41 (Ubuntu) #### Had visits in last 1 day: 0 #### Had visits in last 3 days: 0 #### Had visits in last 5 days: 0 #### Archive Time Last Started: 1616465538 #### Archive Time Last Finished: 1616465549 #### User Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/89.0.4389.90 Safari/537.36 #### Browser Language: en-us,en #### Total Invalidation Count: 12 #### In Progress Invalidation Count: 0 #### Scheduled Invalidation Count: 12 #### Earliest invalidation ts_started: #### Latest invalidation ts_started: #### Earliest invalidation ts_invalidated: 2021-03-23 02:47:27 #### Latest invalidation ts_invalidated: 2021-03-23 02:47:27 #### Number of segment invalidations: 0 #### Number of plugin invalidations: 0 #### List of plugins being invalidated: #### Anonymize Referrer: #### Do Not Track enabled: 0
@diosmosis commented on April 5th 2021 Member

LGTM, merging

This Pull Request was closed on April 5th 2021
Powered by GitHub Issue Mirror