@Findus23 opened this Pull Request on March 31st 2021 Member

The system check LongErrorMessage-boxes were missing the bottom border making them look a bit weird:
image

There is unfortunately a pretty specific rule from another part of Matomo:

table.entityTable tbody tr td {
     border-bottom: 1px solid #f2f2f2 !important;
}

so to make this look correct I also had to make the error rule more specific.
Hopefully the .error class is used nowhere else in Matomo

But I think it should be fine as it is generally defined here:
https://github.com/matomo-org/matomo/blob/703ed9402e4aada544ec94e789021df86575ad15/plugins/Morpheus/stylesheets/simple_structure.css#L188-L193

Review

  • [ ] Functional review done
  • [ ] Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
  • [ ] Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • [ ] Security review done see checklist
  • [ ] Code review done
  • [ ] Tests were added if useful/possible
  • [ ] Reviewed for breaking changes
  • [ ] Developer changelog updated if needed
  • [ ] Documentation added if needed
  • [ ] Existing documentation updated if needed
@diosmosis commented on April 1st 2021 Member

The UI tests look ok and doesn't look like it's used from a quick grep, so should be fine to merge :+1:

This Pull Request was closed on April 1st 2021
Powered by GitHub Issue Mirror