Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

better systemcheck error boxes #17416

Merged
merged 1 commit into from Apr 1, 2021
Merged

Conversation

Findus23
Copy link
Member

The system check LongErrorMessage-boxes were missing the bottom border making them look a bit weird:
image

There is unfortunately a pretty specific rule from another part of Matomo:

table.entityTable tbody tr td {
     border-bottom: 1px solid #f2f2f2 !important;
}

so to make this look correct I also had to make the error rule more specific.
Hopefully the .error class is used nowhere else in Matomo

But I think it should be fine as it is generally defined here:

.error {
font-weight: bold;
font-size: 130%;
border: 1px solid red;
padding: 20px;
}

Review

  • Functional review done
  • Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done see checklist
  • Code review done
  • Tests were added if useful/possible
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed

@Findus23 Findus23 added c: Design / UI For issues that impact Matomo's user interface or the design overall. Needs Review PRs that need a code review labels Mar 31, 2021
@diosmosis
Copy link
Member

The UI tests look ok and doesn't look like it's used from a quick grep, so should be fine to merge 👍

@diosmosis diosmosis added this to the 4.3.0 milestone Apr 1, 2021
@diosmosis diosmosis merged commit fe2b753 into 4.x-dev Apr 1, 2021
@diosmosis diosmosis deleted the nicer-systemcheck-error-boxes branch April 1, 2021 04:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: Design / UI For issues that impact Matomo's user interface or the design overall. Needs Review PRs that need a code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants