Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Calender shows compare to previous period after page reload instead of period year #17414

Closed
flamisz opened this issue Mar 31, 2021 · 1 comment
Closed

Calender shows compare to previous period after page reload instead of period year #17414

flamisz opened this issue Mar 31, 2021 · 1 comment
Labels
Bug For errors / faults / flaws / inconsistencies etc. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.

Comments

@flamisz
Copy link
Contributor

flamisz commented Mar 31, 2021

Expected Behavior

When we choose "compare to previous year" in the calendar, after page reload, we'd like to see "compare to previous year" in the calendar when we open it.

Current Behavior

When we choose "compare to previous year" in the calendar, after page reload, the dates and data are correct, but when we open the calendar, it shows "compare to previous period".

Steps to Reproduce (for Bugs)

  1. Open the calendar and set the period to day, week or month.
  2. Choose "compare to previous year"
  3. Reload the page
  4. Open the calendar and check what it shows

Your Environment

  • Matomo Version: 4.2.1 on demo site

The problem probably is that in the URL we don't save what kind of comparison is that, only the dates, so the data is correct, but the calendar doesn't know it is actually a "compare to previous year".
@flamisz flamisz added Potential Bug Something that might be a bug, but needs validation and confirmation it can be reproduced. Bug For errors / faults / flaws / inconsistencies etc. and removed Potential Bug Something that might be a bug, but needs validation and confirmation it can be reproduced. labels Mar 31, 2021
@mattab
Copy link
Member

mattab commented Dec 11, 2023

Thanks for contributing to this issue. As it has been a few months since the last activity and we believe this is likely not an issue anymore, we will now close this. If that's not the case, please do feel free to either reopen this issue or open a new one. We will gladly take a look again!

@mattab mattab closed this as not planned Won't fix, can't repro, duplicate, stale Dec 11, 2023
@sgiehl sgiehl added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug For errors / faults / flaws / inconsistencies etc. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mattab @sgiehl @flamisz