@diosmosis opened this Pull Request on March 31st 2021 Member

Description:

The warning logs in Row.php are pretty vague about what is actually going on to cause them, making them hard to reproduce and debug. Using exceptions, however, we can get stack traces in the right context.

Looks a bit odd, but it seems to work.

Review

  • [ ] Functional review done
  • [ ] Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
  • [ ] Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • [ ] Security review done see checklist
  • [ ] Code review done
  • [ ] Tests were added if useful/possible
  • [ ] Reviewed for breaking changes
  • [ ] Developer changelog updated if needed
  • [ ] Documentation added if needed
  • [ ] Existing documentation updated if needed
@diosmosis commented on April 1st 2021 Member

Updated. PR was very incorrect before.

This Pull Request was closed on April 1st 2021
Powered by GitHub Issue Mirror