Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use exceptions to provide more context to warning logs in Row.php #17413

Merged
merged 2 commits into from Apr 1, 2021

Conversation

diosmosis
Copy link
Member

Description:

The warning logs in Row.php are pretty vague about what is actually going on to cause them, making them hard to reproduce and debug. Using exceptions, however, we can get stack traces in the right context.

Looks a bit odd, but it seems to work.

Review

  • Functional review done
  • Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done see checklist
  • Code review done
  • Tests were added if useful/possible
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed

@diosmosis diosmosis added the Needs Review PRs that need a code review label Mar 31, 2021
@diosmosis diosmosis added this to the 4.3.0 milestone Mar 31, 2021
core/DataTable/Row.php Outdated Show resolved Hide resolved
@diosmosis
Copy link
Member Author

Updated. PR was very incorrect before.

Copy link
Member

@sgiehl sgiehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks fine now

@sgiehl sgiehl added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. and removed Needs Review PRs that need a code review labels Apr 1, 2021
@sgiehl sgiehl merged commit 2e2ceee into 4.x-dev Apr 1, 2021
@sgiehl sgiehl deleted the logs-with-more-context branch April 29, 2021 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants