Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

track visits in JSTracker UI test to separate site so it does not affect most other tests screenshots #17412

Closed
wants to merge 2 commits into from
Closed

track visits in JSTracker UI test to separate site so it does not affect most other tests screenshots #17412

wants to merge 2 commits into from

Conversation

diosmosis
Copy link
Member

Description:

As title, should stop some random failures in the future.

Review

  • Functional review done
  • Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done see checklist
  • Code review done
  • Tests were added if useful/possible
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed

@diosmosis diosmosis added c: Tests & QA For issues related to automated tests or making it easier to QA & test issues. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels Mar 30, 2021
@diosmosis diosmosis added this to the 4.3.0 milestone Mar 30, 2021
@sgiehl
Copy link
Member

sgiehl commented Mar 31, 2021

@diosmosis the test is failing. Seems the site that's used now actually doesn't exist

@diosmosis diosmosis removed the Needs Review PRs that need a code review label Apr 1, 2021
@diosmosis diosmosis marked this pull request as draft April 1, 2021 04:37
@diosmosis
Copy link
Member Author

Noticed the UI test uses a custom fixture, so this wouldn't affect the other tests... Not sure why the others change when the order changes, then. Closing this one.

@diosmosis diosmosis closed this Apr 6, 2021
@diosmosis diosmosis deleted the js-ui-test-new-site branch April 6, 2021 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
c: Tests & QA For issues related to automated tests or making it easier to QA & test issues. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
4.3.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@diosmosis @sgiehl