@diosmosis opened this Pull Request on March 30th 2021 Member

Description:

As title, should stop some random failures in the future.

Review

  • [ ] Functional review done
  • [ ] Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
  • [ ] Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • [ ] Security review done see checklist
  • [ ] Code review done
  • [ ] Tests were added if useful/possible
  • [ ] Reviewed for breaking changes
  • [ ] Developer changelog updated if needed
  • [ ] Documentation added if needed
  • [ ] Existing documentation updated if needed
@sgiehl commented on March 31st 2021 Member

@diosmosis the test is failing. Seems the site that's used now actually doesn't exist

@diosmosis commented on April 6th 2021 Member

Noticed the UI test uses a custom fixture, so this wouldn't affect the other tests... Not sure why the others change when the order changes, then. Closing this one.

This Pull Request was closed on April 6th 2021
Powered by GitHub Issue Mirror