Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes possible notice #17410

Merged
merged 1 commit into from Apr 1, 2021
Merged

Fixes possible notice #17410

merged 1 commit into from Apr 1, 2021

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Mar 30, 2021

Description:

Review

  • Functional review done
  • Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done see checklist
  • Code review done
  • Tests were added if useful/possible
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed

@sgiehl sgiehl added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels Mar 30, 2021
@sgiehl sgiehl added this to the 4.3.0 milestone Mar 30, 2021
sgiehl
sgiehl commented Mar 30, 2021
View reviewed changes
core/SupportedBrowser.php
@@ -50,7 +50,7 @@ public static function checkIfBrowserSupported()
$deviceDetector->parse();
$client = $deviceDetector->getClient();

if ($client['type'] === 'browser' && self::browserNotSupported($client['short_name'], (int)$client['version'])) {
if (!empty($client) && $client['type'] === 'browser' && self::browserNotSupported($client['short_name'], (int)$client['version'])) {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If device detector isn't able to detect any client the result of getClient() actually can be null, which then resulted in a notice here.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch 👍

@diosmosis diosmosis merged commit 6a00859 into 4.x-dev Apr 1, 2021
@diosmosis diosmosis deleted the fixnotice branch April 1, 2021 04:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flamisz flamisz flamisz approved these changes

Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
4.3.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sgiehl @flamisz @diosmosis