Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build #17406

Merged
merged 2 commits into from Mar 29, 2021
Merged

Fix build #17406

merged 2 commits into from Mar 29, 2021

Conversation

diosmosis
Copy link
Member

Description:

API listing needed to be updated. I believe the other failures are due to change in order of test runs (which can happen when a new test is run). Some tests track in the UI test so I guess they have an effect on other tests. Might be worth looking into if time ever frees up or someone stumbles upon why.

Review

  • Functional review done
  • Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done see checklist
  • Code review done
  • Tests were added if useful/possible
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed

@diosmosis diosmosis added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Mar 29, 2021
@diosmosis diosmosis added this to the 4.3.0 milestone Mar 29, 2021
@diosmosis diosmosis merged commit c0cd97f into 4.x-dev Mar 29, 2021
@diosmosis diosmosis deleted the fix-build branch March 29, 2021 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant