Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates tecnickcom/tcpdf #17405

Merged
merged 2 commits into from Mar 29, 2021
Merged

Updates tecnickcom/tcpdf #17405

merged 2 commits into from Mar 29, 2021

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Mar 29, 2021

Description:

This PHP 8 compatible version has been released 2 days ago

refs #16897

Review

  • Functional review done
  • Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done see checklist
  • Code review done
  • Tests were added if useful/possible
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed

@sgiehl sgiehl added Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change. Needs Review PRs that need a code review labels Mar 29, 2021
@sgiehl sgiehl added this to the 4.3.0 milestone Mar 29, 2021
@sgiehl sgiehl merged commit 367547e into 4.x-dev Mar 29, 2021
@sgiehl sgiehl deleted the update-tcpdf branch March 29, 2021 14:43
@mattab mattab added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label May 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Projects
None yet
Milestone
4.3.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sgiehl @mattab