New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add a new stale action #17404
add a new stale action #17404
Conversation
let me know if you happy with this @tsteur |
thanks @flamisz that's great. Do you have maybe a link to a summary what actions it would do? Can we maybe tweak @mattab @sgiehl @diosmosis @Findus23 be great to read over the config as well. There are two different actions one for |
Does that really work as expected. The action actually produces this warning: |
There is a limit on operations, you can read about it here: https://github.com/actions/stale#operations-per-run |
@tsteur I modified the stale message. Please check if it is ok now.
What do you mean? A summary about dry runs, so we know what would have happened? |
@flamisz yes that be great. Just so we know it would do the right thing and that it'll work and won't the wrong PRs etc |
Short summary for the Yesterday it found this PR #17394 and wanted to stale it, which means add a I checked the result for a run couple of days ago, and it didn't stale it, because it was updated less than 7 days ago (that time). The same happened with this one #17387. Skipped all the PR without the required label (Needs review). It goes through the issues/PRs by the last updated date, descending. It runs 30 operations per run (by default). I'm not sure what is one operation when it's in production mode, so we will see how it works, how many PRs will be checked per run. It runs once daily. |
Handle inactive PRs A couple of pr (like #17333 ) got stale during yesterday's run. No PR has been closed, because we check PRs only from 1st March and the days before close is set to 42. |
Thanks @flamisz Any more thoughts @mattab @sgiehl @diosmosis @Findus23 ? We'd otherwise activate it and would just need to keep an eye on it that we don't accidentally close a false PR. Regarding closing stale PRs. I wonder if we'd need to change to something like this if that's possible:
Not sure if that makes sense or is clear what I'm thinking of? Fingers crossed it's possible to configure this. |
Unfortunately, I don't think it's that flexible. I take a look, but I doubt it. The best we can do is checking the labels probably, but that has to be handled by us, and we forget it, etc. |
@tsteur I checked the action, what is the best we can do, regarding to checking who was the last who did something with the PR. Do you want me to add this to the yaml file? |
@tsteur we were talking about to do not close the PR automatically only add a comment, but this is not possible with this action. It closes the PR when adds the close comment and optional label. |
@flamisz don't we also just add a comment with the other action after 7 days? Was hoping it could look similar to https://github.com/matomo-org/matomo/pull/17404/files#diff-487d40658fdc47419d39d147a502671a427a1df852c41b5555b382ae515111d7R12-R20 or maybe I forgot about something? |
@tsteur sure we can do that, what we can't do is add a comment after 7 days, and then a new one after 42 days, because the 2nd comment would close the PR. If we want to make 2 warnings (one at day 7, and one at day 42) we need a new action. What do you think we should do here? We can add a comment with mentions to us at day 7, and than close it or not close it at day 42? We can add a new comment with mentions on that day too, and we can reopen if it was a mistake. |
We could use a new action and we wouldn't want to close it automatically. Only a comment be great 👍 |
we can then always change later again |
@tsteur I added a new action. Do you think we should give it a try like this, but still just dry-run? I week maybe, and we can go live the week after. |
sure sounds good @flamisz |
I test with the new settings for one more week |
Description:
refs #17318 #17344
I checked the logs of the dry runs and actually did not find any when actually it would comment on any or. The current setup checks only PRs (not issues) and only PRs were created after 2021-03-01.
Review