Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix API description for ScheduledReports #17401

Merged
merged 2 commits into from Mar 29, 2021
Merged

fix API description for ScheduledReports #17401

merged 2 commits into from Mar 29, 2021

Conversation

Findus23
Copy link
Member

@Findus23 Findus23 commented Mar 28, 2021 •
edited by sgiehl

I don't think there is any sendEmailReport and the description is meant to say sendReport.

Review

  • Functional review done
  • Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done see checklist
  • Code review done
  • Tests were added if useful/possible
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed

@Findus23 Findus23 added Needs Review PRs that need a code review c: Documentation For issues related to in-app product help messages, or to the Matomo knowledge base. labels Mar 28, 2021
@sgiehl sgiehl removed the Needs Review PRs that need a code review label Mar 29, 2021
@sgiehl sgiehl added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Mar 29, 2021
@sgiehl sgiehl added this to the 4.3.0 milestone Mar 29, 2021
@sgiehl sgiehl merged commit e9a5f9d into 4.x-dev Mar 29, 2021
@sgiehl sgiehl deleted the ScheduledReportsAPIDocs branch March 29, 2021 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgiehl sgiehl sgiehl approved these changes

Assignees
No one assigned
Labels
c: Documentation For issues related to in-app product help messages, or to the Matomo knowledge base. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
4.3.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Findus23 @sgiehl