@Findus23 opened this Pull Request on March 24th 2021 Member

This is quite subjective, but I think it looks nicer if there is also an icon for informational entries

Before:
grafik

Now:
grafik

One could use icon-info instead as it looks a bit nicer, but it doesn't fit the style of the other icons.

Review

  • [x] Functional review done
  • [x] Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
  • [x] Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • [x] Security review done see checklist
  • [x] Code review done
  • [ ] Tests were added if useful/possible
  • [x] Reviewed for breaking changes
  • [x] Developer changelog updated if needed
  • [x] Documentation added if needed
  • [x] Existing documentation updated if needed
@Findus23 commented on March 24th 2021 Member

Also there don't seem to be a LESS variable for the error/warning/info/sucess colors, so I copied the ones from notifications over.

If you are interested I could create a PR unifying them over all of Matomo.

@flamisz commented on March 24th 2021 Contributor

These are the before-after screenshots, to make it easier to decide which one is preferred:

Screen Shot 2021-03-25 at 8 43 41 AMScreen Shot 2021-03-25 at 8 44 20 AM
@Findus23 commented on March 24th 2021 Member

If someone doesn't like the icons in the informational results we could maybe remove them just there

@sgiehl commented on March 25th 2021 Member

Personally I like the change. Maybe @tsteur or @mattab could state their opinion as well.
@Findus23 Guess the expected UI files would need an update before we could merge it...

@tsteur commented on March 25th 2021 Member

All good 👍

@Findus23 commented on March 25th 2021 Member

Just noticed while updating tests that there is a separate CSS file for the installer.

This Pull Request was closed on March 25th 2021
Powered by GitHub Issue Mirror