Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make sure no rearchiving happens if INI config setting is set to 0 or last0 + add extra sanity check. #17386

Merged
merged 1 commit into from Mar 24, 2021
Merged

make sure no rearchiving happens if INI config setting is set to 0 or last0 + add extra sanity check. #17386

merged 1 commit into from Mar 24, 2021

Conversation

diosmosis
Copy link
Member

Description:

Refs #17368

Review

  • Functional review done
  • Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done see checklist
  • Code review done
  • Tests were added if useful/possible
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed

@diosmosis diosmosis added the Needs Review PRs that need a code review label Mar 24, 2021
@diosmosis diosmosis added this to the 4.3.0 milestone Mar 24, 2021
nelhefni
nelhefni reviewed Mar 24, 2021
View reviewed changes
Copy link

@nelhefni nelhefni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!!

@diosmosis diosmosis merged commit eb1a6ba into 4.x-dev Mar 24, 2021
@diosmosis diosmosis deleted the rearchive-in-past-zero branch March 24, 2021 15:18
@nelhefni
Copy link

@diosmosis thanks for the fix! do you know when it could be released?

@mattab mattab added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label May 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nelhefni nelhefni nelhefni left review comments

@tsteur tsteur tsteur approved these changes

Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
4.3.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@diosmosis @nelhefni @tsteur @mattab