Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix download test #17384

Merged
merged 1 commit into from Mar 23, 2021
Merged

Fix download test #17384

merged 1 commit into from Mar 23, 2021

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Mar 23, 2021

Description:

The test that tries downloading something from https://tools.ietf.org/html/rfc7233 currently fails quite often due to connectivity issues of their servers. Using our build download instead hopefully works better...

Review

  • Functional review done
  • Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done see checklist
  • Code review done
  • Tests were added if useful/possible
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed

@sgiehl sgiehl added c: Tests & QA For issues related to automated tests or making it easier to QA & test issues. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. labels Mar 23, 2021
@sgiehl sgiehl added this to the 4.3.0 milestone Mar 23, 2021
@diosmosis diosmosis merged commit d3dd029 into 4.x-dev Mar 23, 2021
@diosmosis diosmosis deleted the fixtest branch March 23, 2021 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: Tests & QA For issues related to automated tests or making it easier to QA & test issues. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants