Ensure correct rowaction instances are used #17383
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
It took me a while debugging to figure out where the reason for #17374 was. It turned out that when loading a subtable handling the row actions was not only called for the subtable, but also for the parent table (caused by using
.parents
instead of.closest
).Due to this the
actionInstances
used to bind the events were bound multiple times for the parent table, causing some weird behavior where sometimes the wrong datatable was used to trigger the row action.fixes #17374
fixes matomo-org/plugin-MarketingCampaignsReporting#61
Review