Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure correct rowaction instances are used #17383

Merged
merged 1 commit into from Mar 23, 2021
Merged

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Mar 23, 2021

Description:

It took me a while debugging to figure out where the reason for #17374 was. It turned out that when loading a subtable handling the row actions was not only called for the subtable, but also for the parent table (caused by using .parents instead of .closest).
Due to this the actionInstances used to bind the events were bound multiple times for the parent table, causing some weird behavior where sometimes the wrong datatable was used to trigger the row action.

fixes #17374
fixes matomo-org/plugin-MarketingCampaignsReporting#61

Review

  • Functional review done
  • Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done see checklist
  • Code review done
  • Tests were added if useful/possible
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed

@sgiehl sgiehl added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels Mar 23, 2021
@sgiehl sgiehl added this to the 4.3.0 milestone Mar 23, 2021
@sgiehl sgiehl requested a review from diosmosis March 23, 2021 12:43
@diosmosis diosmosis merged commit 1243523 into 4.x-dev Mar 23, 2021
@diosmosis diosmosis deleted the fixrowactions branch March 23, 2021 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
2 participants