New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show notification when there is raw data but no data #17380
Conversation
The original issue says:
This solution works with segments as well but easy to disable if we don't want to support yet. Is it ok if it works with segments @tsteur? Update: the |
plugins/CoreHome/angularjs/reporting-menu/reportingmenu-model.js
Outdated
Show resolved
Hide resolved
plugins/CoreHome/angularjs/reporting-menu/reportingmenu.controller.js
Outdated
Show resolved
Hide resolved
plugins/CoreHome/angularjs/reporting-menu/reportingmenu-model.js
Outdated
Show resolved
Hide resolved
plugins/CoreHome/angularjs/reporting-menu/reportingmenu-model.js
Outdated
Show resolved
Hide resolved
plugins/CoreHome/angularjs/reporting-menu/reportingmenu-model.js
Outdated
Show resolved
Hide resolved
plugins/CoreHome/angularjs/reporting-menu/reportingmenu.controller.js
Outdated
Show resolved
Hide resolved
plugins/CoreHome/angularjs/reporting-menu/reportingmenu.controller.js
Outdated
Show resolved
Hide resolved
plugins/CoreHome/angularjs/reporting-page/reportingpage.controller.js
Outdated
Show resolved
Hide resolved
plugins/CoreHome/angularjs/reporting-page/reportingpage.directive.html
Outdated
Show resolved
Hide resolved
bedbe21
to
582cd3a
Compare
1ed3ec9
to
346cc31
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks go to me now. We could theoretically try to add a new UI test that shows this notification. But that might not be too easy. UI tests by default run the archiving, so by default reports would be generated when you add a visit for today. Guess we could maybe use an empty fixture and send a tracking request for today in the UI test itself or something like that.
I tried to add that test, but couldn't make it work. I tried this inside the const trackerUrl = config.piwikUrl + "matomo.php?action_name=&idsite=1&url=http://piwik.net/test/url";
await request({
method: 'POST',
uri: trackerUrl,
});
await page.goto(pageUrl);
expect(await page.screenshot({ fullPage: true })).to.matchImage('show_notification_when_only_raw_data_exists'); But there is no new log in the db... matomo/tests/UI/specs/OneClickUpdate_spec.js Lines 85 to 97 in 3ab0d4e
EDIT: I talked to @tsteur about this, he showed me a couple of things in the tests, so I try to make it work. |
@tsteur and @sgiehl I figured what was the problem and what is the solution. Even when I called the tracker it didn't work, because when we load the page that triggers the archiving, so I need to add this to test, and I don't need any extra tracker call this way.: testEnvironment.configOverride.General = {
browser_archiving_disabled_enforce: '1',
enable_browser_archiving_triggering: '0',
};
testEnvironment.optionsOverride = {
enableBrowserTriggerArchiving: '0',
}; Only one thing that came up now. We show this notification only if today's date is in the date range. I couldn't find a way to mock the today in the UI tests. Are we happy with it if the test uses today every time? It means we can have some false negatives, when the tests run around midnight. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be good to merge now
Description:
fixes #16790
Review