@sgiehl opened this Pull Request on March 22nd 2021 Member

Description:

refs #17371

Review

  • [ ] Functional review done
  • [ ] Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
  • [ ] Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • [ ] Security review done see checklist
  • [ ] Code review done
  • [ ] Tests were added if useful/possible
  • [ ] Reviewed for breaking changes
  • [ ] Developer changelog updated if needed
  • [ ] Documentation added if needed
  • [ ] Existing documentation updated if needed
@sgiehl commented on March 22nd 2021 Member

build js

@diosmosis commented on March 22nd 2021 Member

Should we maybe do this server side as well to be safe in case people use the tracker API directly or use log importing?

@sgiehl commented on March 23rd 2021 Member

@diosmosis looking at the code it seems the values should actually already be casted to integer server side. At least they are defined as those here:
https://github.com/matomo-org/matomo/blob/23d551750442d12975ee9c2af6f73ac9bbf75c1a/core/Tracker/Request.php#L415-L420

So the changes here actually won't have a big effect. But it's still useless to send floats if we use them as integers...

@diosmosis commented on March 23rd 2021 Member

makes sense :+1:

This Pull Request was closed on March 23rd 2021
Powered by GitHub Issue Mirror