Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

French country map: Add ISO 3166-2 new codes + update regions #17370

Merged
merged 1 commit into from Mar 22, 2021

Conversation

ysard
Copy link
Contributor

@ysard ysard commented Mar 22, 2021

Description:

Hi I partially reverse-engineered the /plugins/UserCountryMap/svg/FRA.svg file to update it in accordance with the regrouping of French regions since January 1, 2016. namely:

  • removal of old regions
  • addition of ISO 3166-2 codes in the additional attribute (data-p) of <path> objects, as it is the case for other countries without any problem of ISO code. It's a trick but it works.

See the Wikipedia page for more info about this administrative update.
Finally, we have 13 metropolitan regions instead of 22.

Editing was made with Inkscape. The method is not reproducible due to the lack of a functional map generator,
but I suppose that it's better than nothing...
However, it should be noted that even Natural Earth Data is not up to date on this point.
See the issue here

This closes issue #15203 and is related to #11929.

Demonstration image:
image

Review

  • Functional review done
  • Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done see checklist
  • Code review done
  • Tests were added if useful/possible
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed

…e svg paths in accordance with the division of regions fix matomo-org#15203
@sgiehl sgiehl added the Needs Review PRs that need a code review label Mar 22, 2021
Copy link
Member

@sgiehl sgiehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ysard
Thanks for creating the PR. Very appreciated.
Tested it locally and it works nicely 👍

@sgiehl sgiehl added this to the 4.3.0 milestone Mar 22, 2021
@sgiehl sgiehl removed the Needs Review PRs that need a code review label Mar 22, 2021
@sgiehl sgiehl linked an issue Mar 22, 2021 that may be closed by this pull request
@sgiehl sgiehl merged commit b93f640 into matomo-org:4.x-dev Mar 22, 2021
@sgiehl sgiehl added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Apr 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

France regions are not up-to-date
2 participants