@diosmosis opened this Pull Request on March 22nd 2021 Member

Description:

Allow forcing the backtrace to print in ExceptionToTextProcessor + a fix: remove the redundant message that gets printed when including the backtrace. The processor printed the message + the stack trace, but the stack trace includes the messages of all exceptions, so it's redundant. We could also always use the result of getMessageAndWholeBacktrace(), but I didn't want to change that much code for a small change.

Review

  • [ ] Functional review done
  • [ ] Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
  • [ ] Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • [ ] Security review done see checklist
  • [ ] Code review done
  • [ ] Tests were added if useful/possible
  • [ ] Reviewed for breaking changes
  • [ ] Developer changelog updated if needed
  • [ ] Documentation added if needed
  • [ ] Existing documentation updated if needed
@diosmosis commented on March 22nd 2021 Member

I remember, that was to keep it backwards compatible w/ some uses, probably fatal error reporting. I'll take a look.

@diosmosis commented on March 23rd 2021 Member

Can't see an array ever being used w/ this method, so I'm just going to change it and see if any tests fail. Worst case, the message may get printed out twice in some rare circumstances, so I think it's ok.

@sgiehl commented on March 23rd 2021 Member

@diosmosis there are various log related tests failing

This Pull Request was closed on March 25th 2021
Powered by GitHub Issue Mirror