allow forcing backtrace to print in exceptiontotextprocessor #17369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n exceptiontotextprocessor
sgiehl
reviewed
Mar 22, 2021
There was a problem hiding this comment.
The code itself looks good.
@diosmosis could you have a look at the method getMessageAndWholeBacktrace? I'm wondering if it is on purpose that the message actually is not included if $exception is given as array. Not sure when that is the case, but imho it should also include the message in that case, right?
|
I remember, that was to keep it backwards compatible w/ some uses, probably fatal error reporting. I'll take a look. |
|
Can't see an array ever being used w/ this method, so I'm just going to change it and see if any tests fail. Worst case, the message may get printed out twice in some rare circumstances, so I think it's ok. |
|
@diosmosis there are various log related tests failing |
sgiehl
approved these changes
Mar 25, 2021
mattab
added
the
not-in-changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Allow forcing the backtrace to print in ExceptionToTextProcessor + a fix: remove the redundant message that gets printed when including the backtrace. The processor printed the message + the stack trace, but the stack trace includes the messages of all exceptions, so it's redundant. We could also always use the result of
getMessageAndWholeBacktrace(), but I didn't want to change that much code for a small change.Review