@flamisz opened this Pull Request on March 22nd 2021 Contributor

Description:

fixes #16787

Review

  • [ ] Functional review done
  • [ ] Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
  • [ ] Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • [ ] Security review done see checklist
  • [ ] Code review done
  • [ ] Tests were added if useful/possible
  • [ ] Reviewed for breaking changes
  • [ ] Developer changelog updated if needed
  • [ ] Documentation added if needed
  • [ ] Existing documentation updated if needed
@flamisz commented on March 22nd 2021 Contributor

Couple of example websites I used trying different CMSs:

type site
matomo.org - WP http://matomo.org
squarespace https://est-bostoncopywriter.com
wix https://www.thegrilledcheesefactory.fr
joomla https://www.nintendo.se
shopify + GTM https://www.manitobah.com
sharepoint https://incometaxindia.gov.in
@flamisz commented on March 22nd 2021 Contributor

Hi @tsteur,
the current page checks the WhiteLabel plugin and hides URLs (not all tho) to matomo.org. How strictly we'd like to follow that in the new solution? All the links that go to matomo.org? That way we can't show any instructions/guides from the FAQ. And what about links from the development documentation?

These are the links I use now:

  • CMS integration guides
  • GTM guide
  • the /integrate page from matomo.org
  • tracking dev documentation
  • tag manager guide
  • and guides for the other pages (log analytics, SDKs, HTTP tracking guide)

Thanks, Zoltan

@tsteur commented on March 22nd 2021 Member

The links to matomo.org should be fine (they were basically there before already). Also links to the developer website should be no problem @flamisz

@flamisz commented on March 24th 2021 Contributor

I'll add the test for that cms type guess method.

@flamisz commented on March 25th 2021 Contributor

As you can see there is a linked PR, matomo-org/tag-manager#307. I needed that, because inside the tabs, when we show the tagmanager code, without that change the user has to change the site and then change back, to show the containers.

But now I've found another issue. When the tabs are loaded, using the widget-loader and calls the tagmanager code includes the siteselector, and that throws an error from here:
https://github.com/matomo-org/matomo/blob/eb1a6ba1ff8a0a486f963eb4087714e94a9a4d12/plugins/CoreHome/angularjs/siteselector/siteselector.controller.js#L16

I remembered @sgiehl modified that part a couple of weeks ago. If I modify back to the original code, it works. It looks like the issue is that...

Ok, nothing (but I comment it anyway 😄 ) I see there is a new commit from @sgiehl and it has been fixed...
Is it ok if I rebase my branch?

@diosmosis commented on March 25th 2021 Member

Is it ok if I rebase my branch?

This would never be an issue :+1:

This Pull Request was closed on March 29th 2021
Powered by GitHub Issue Mirror