fixes #16787
Couple of example websites I used trying different CMSs:
type | site |
---|---|
matomo.org - WP | http://matomo.org |
squarespace | https://est-bostoncopywriter.com |
wix | https://www.thegrilledcheesefactory.fr |
joomla | https://www.nintendo.se |
shopify + GTM | https://www.manitobah.com |
sharepoint | https://incometaxindia.gov.in |
Hi @tsteur,
the current page checks the WhiteLabel plugin and hides URLs (not all tho) to matomo.org
. How strictly we'd like to follow that in the new solution? All the links that go to matomo.org
? That way we can't show any instructions/guides from the FAQ. And what about links from the development documentation?
These are the links I use now:
/integrate
page from matomo.org
Thanks, Zoltan
The links to matomo.org should be fine (they were basically there before already). Also links to the developer website should be no problem @flamisz
As you can see there is a linked PR, matomo-org/tag-manager#307. I needed that, because inside the tabs, when we show the tagmanager
code, without that change the user has to change the site and then change back, to show the containers.
But now I've found another issue. When the tabs are loaded, using the widget-loader
and calls the tagmanager code includes the siteselector, and that throws an error from here:
https://github.com/matomo-org/matomo/blob/eb1a6ba1ff8a0a486f963eb4087714e94a9a4d12/plugins/CoreHome/angularjs/siteselector/siteselector.controller.js#L16
I remembered @sgiehl modified that part a couple of weeks ago. If I modify back to the original code, it works. It looks like the issue is that...
Ok, nothing (but I comment it anyway 😄 ) I see there is a new commit from @sgiehl and it has been fixed...
Is it ok if I rebase my branch?
Is it ok if I rebase my branch?
This would never be an issue :+1: