Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warning in 2fa setting: gmdate() expects parameter 2 to be int #17365

Merged
merged 1 commit into from Mar 21, 2021

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented Mar 21, 2021

see https://forum.matomo.org/t/problem-with-the-two-factor-authentication-setting/41128/12?

WARNING: /Piwik/core/Cookie.php(155): Warning - gmdate() expects parameter 2 to be int, float given - Matomo 4.1.1 - Please report this message in the Matomo forums: https://forum.matomo.org (please do a search first as it might have been reported already) (Module: UsersManager, Action: setIgnoreCookie, In CLI mode: false)

Review

  • Functional review done
  • Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done see checklist
  • Code review done
  • Tests were added if useful/possible
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed

see https://forum.matomo.org/t/problem-with-the-two-factor-authentication-setting/41128/12?

> WARNING: /Piwik/core/Cookie.php(155): Warning - gmdate() expects parameter 2 to be int, float given - Matomo 4.1.1 - Please report this message in the Matomo forums: https://forum.matomo.org (please do a search first as it might have been reported already) (Module: UsersManager, Action: setIgnoreCookie, In CLI mode: false)
@tsteur tsteur added the Needs Review PRs that need a code review label Mar 21, 2021
@tsteur tsteur added this to the 4.3.0 milestone Mar 21, 2021
@diosmosis diosmosis merged commit 3599441 into 4.x-dev Mar 21, 2021
@diosmosis diosmosis deleted the gmdateint branch March 21, 2021 20:57
@mattab mattab changed the title Ensure second parameter in gmdate is int, not float Fixes "Warning - gmdate() expects parameter 2 to be int," May 17, 2021
@mattab mattab changed the title Fixes "Warning - gmdate() expects parameter 2 to be int," Getting warning in 2fa setting: gmdate() expects parameter 2 to be int May 17, 2021
@mattab mattab changed the title Getting warning in 2fa setting: gmdate() expects parameter 2 to be int Warning in 2fa setting: gmdate() expects parameter 2 to be int May 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants