Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

check for openssl extension #17364

Merged
merged 3 commits into from Mar 21, 2021
Merged

check for openssl extension #17364

merged 3 commits into from Mar 21, 2021

Conversation

Findus23
Copy link
Member

bit related to #17363

This is already indirectly covered by SystemCheckUpdateHttpsNotSupported, but having a bit more explicit might not hurt as having HTTPS support is really important.

Review

  • Functional review done
  • Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done see checklist
  • Code review done
  • Tests were added if useful/possible
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed

@Findus23 Findus23 added the Needs Review PRs that need a code review label Mar 21, 2021
@diosmosis diosmosis added this to the 4.3.0 milestone Mar 21, 2021
@diosmosis diosmosis merged commit d173509 into 4.x-dev Mar 21, 2021
@diosmosis diosmosis deleted the recommend-openssl branch March 21, 2021 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Needs Review PRs that need a code review
Projects
None yet
Milestone
4.3.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Findus23 @diosmosis