Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check for filter, hash and session php extensions #17363

Merged
merged 3 commits into from Mar 21, 2021

Conversation

Findus23
Copy link
Member

fixes #17362

All three extensions are normally included in PHP when using the default compile parameters, but you can compile PHP without them, so it is possible that they are missing which breaks Matomo.

Weirdly the translation string for Installation_SystemCheckHashHelp already existed.

I also changed SystemCheckWarnJsonHelp as I doubt Matomo will work at all without json support. (and it is in the list of required extensions)

Review

  • Functional review done
  • Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done see checklist
  • Code review done
  • Tests were added if useful/possible
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed

@Findus23 Findus23 added the Needs Review PRs that need a code review label Mar 21, 2021
@Findus23 Findus23 mentioned this pull request Mar 21, 2021
10 tasks
@diosmosis diosmosis merged commit d01a55e into 4.x-dev Mar 21, 2021
@diosmosis
Copy link
Member

Thanks @Findus23 for picking up the issue and creating this (and the other) pr! 👍

@diosmosis diosmosis deleted the better-extension-check branch March 21, 2021 20:50
@diosmosis diosmosis added this to the 4.3.0 milestone Mar 21, 2021
@diosmosis diosmosis added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Mar 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Installer starts over after asking super user details
2 participants