Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix remaining regressions & ui tests #17360

Merged
merged 7 commits into from Mar 21, 2021
Merged

Fix remaining regressions & ui tests #17360

merged 7 commits into from Mar 21, 2021

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Mar 19, 2021

Description:

While checking the remaining failing UI tests I've detected some more regressions from the latest merged PRs

Review

  • Functional review done
  • Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done see checklist
  • Code review done
  • Tests were added if useful/possible
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed

@sgiehl sgiehl added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review Regression Indicates a feature used to work in a certain way but it no longer does even though it should. labels Mar 19, 2021
@sgiehl sgiehl added this to the 4.3.0 milestone Mar 19, 2021
sgiehl
sgiehl commented Mar 19, 2021
View reviewed changes
plugins/CoreHome/angularjs/reporting-menu/reportingmenu.controller.js
@@ -218,7 +220,9 @@
});

$rootScope.$on('piwikPageChange', function (event) {
globalAjaxQueue.abort();
if (!initialLoad) {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should ensure that when the page loads initially it doesn't abort any ajax requests. Otherwise this makes problems when directly loading a popover with url params. Some UI tests where failing due to aborted requests.

@sgiehl
Copy link
Member Author

sgiehl commented Mar 19, 2021

Seems all tests are passing again 🎉

@diosmosis diosmosis merged commit 9a9e57b into 4.x-dev Mar 21, 2021
@diosmosis diosmosis deleted the fixuitests branch March 21, 2021 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Regression Indicates a feature used to work in a certain way but it no longer does even though it should.
Projects
None yet
Milestone
4.3.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sgiehl @diosmosis