Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure login allow list is not checked for authenticated tracking requests #17357

Merged
merged 3 commits into from Mar 21, 2021
Merged

Ensure login allow list is not checked for authenticated tracking requests #17357

merged 3 commits into from Mar 21, 2021

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Mar 18, 2021

Description:

fixes matomo-org/plugin-VisitorGenerator#66

Review

  • Functional review done
  • Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done see checklist
  • Code review done
  • Tests were added if useful/possible
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed

@sgiehl sgiehl added the Needs Review PRs that need a code review label Mar 18, 2021
@sgiehl sgiehl added this to the 4.3.0 milestone Mar 18, 2021
diosmosis
diosmosis requested changes Mar 18, 2021
View reviewed changes
tests/PHPUnit/System/TrackerDisallowedIpTest.php Show resolved Hide resolved
plugins/CoreHome/CoreHome.php Outdated Show resolved Hide resolved
@sgiehl sgiehl requested a review from diosmosis March 19, 2021 08:37
@diosmosis diosmosis merged commit f100736 into 4.x-dev Mar 21, 2021
@diosmosis diosmosis deleted the authtracking branch March 21, 2021 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diosmosis diosmosis Awaiting requested review from diosmosis

Assignees
No one assigned
Labels
Needs Review PRs that need a code review
Projects
None yet
Milestone
4.3.0
Development

Successfully merging this pull request may close these issues.

Tracking failure when using plugin in Matomo 4.1.1
2 participants
@sgiehl @diosmosis