Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workflows for handling inactive prs #17354

Merged
merged 1 commit into from Mar 18, 2021
Merged

workflows for handling inactive prs #17354

merged 1 commit into from Mar 18, 2021

Conversation

flamisz
Copy link
Contributor

@flamisz flamisz commented Mar 17, 2021

Description:

fixes #17318
fixes #17344

Review

  • Functional review done
  • Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done see checklist
  • Code review done
  • Tests were added if useful/possible
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed

@flamisz flamisz added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels Mar 17, 2021
@flamisz flamisz self-assigned this Mar 17, 2021
@tsteur tsteur merged commit a7cd9b6 into 4.x-dev Mar 18, 2021
@tsteur tsteur deleted the close-stale-issues branch March 18, 2021 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automatically comment on PRs after inactivity Making sure we review all pull requests
2 participants