Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Channel Overview Widget initially too small--> Goals Overview #17353

Open
utrautmann opened this issue Mar 17, 2021 · 4 comments
Open

Channel Overview Widget initially too small--> Goals Overview #17353

utrautmann opened this issue Mar 17, 2021 · 4 comments
Labels
Bug For errors / faults / flaws / inconsistencies etc. c: Design / UI For issues that impact Matomo's user interface or the design overall.
Milestone
For Prioritization

Comments

@utrautmann
Copy link

When I click in the Goals menu and then Overview, the widget for the Channel type is loaded too small relatively often.
See the screenshots.
A reload helps.

Unfortunately I cannot reproduce it on https://demo.matomo.cloud/, but on few own installations.
It seems to occur when the response speed from the server is not very fast.

An JavaScript error does not happen at the browser console.

Environment

  • Matomo Version: 4.2.1 and older
  • Browser: Firefox, Chrome (current versions)
  • Operating System: Windows, Mac

Here I show two screens from different installations:

grafik

grafik
@utrautmann utrautmann added the Potential Bug Something that might be a bug, but needs validation and confirmation it can be reproduced. label Mar 17, 2021
@diosmosis
Copy link
Member

@utrautmann I tried adding a sleep(5); to my index.php but still I'm not able to reproduce this. How long does it take for your requests to finish?

@utrautmann
Copy link
Author

Hi @diosmosis ,

I uploaded a screencast video here. If you slow down the playback, you will see between 00:01 and 00:02 seconds that the Channel Type widget is already displayed, but the 4 goals are still loaded. See also my screenshot from that moment.
At the end of the video you will see that the Channel Type widget is empty (has no data) when I scroll to right.
Could be a competition problem between the different requests.

grafik

@diosmosis
Copy link
Member

Hi @utrautmann, apologies for the late reply, definitely looks like a bug, though it might be hard to track this one down. Thanks again for reporting it!

@diosmosis diosmosis added Bug For errors / faults / flaws / inconsistencies etc. c: Design / UI For issues that impact Matomo's user interface or the design overall. and removed Potential Bug Something that might be a bug, but needs validation and confirmation it can be reproduced. labels Apr 11, 2021
@diosmosis
Copy link
Member

I was able to reproduce this by chance on cloud. The problem appears to be this code: https://github.com/matomo-org/matomo/blob/4.x-dev/plugins/CoreHome/javascripts/dataTable.js#L415-L421 which sets the max-width to 60px. It happens if this logic is executed while the widget is not shown (ng-hide is on the widget containing the table). The max width is then set too early. A timeout would probably be a quick fix, possibly one that checks if the table is visible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug For errors / faults / flaws / inconsistencies etc. c: Design / UI For issues that impact Matomo's user interface or the design overall.
Projects
None yet
Milestone
For Prioritization
Development

No branches or pull requests
3 participants
@diosmosis @utrautmann @innocraft-automation