Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure site is selected in siteselector if only one site is available #17349

Merged
merged 1 commit into from Mar 17, 2021
Merged

Ensure site is selected in siteselector if only one site is available #17349

merged 1 commit into from Mar 17, 2021
+6 −2

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Mar 16, 2021

Description:

When only one site is available the site selector does no longer provide the possibility to choose one. In this case this site should be automatically set as the selected one.

regression from #16972

Review

  • Functional review done
  • Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done see checklist
  • Code review done
  • Tests were added if useful/possible
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed

@sgiehl sgiehl added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review Regression Indicates a feature used to work in a certain way but it no longer does even though it should. labels Mar 16, 2021
@sgiehl sgiehl added this to the 4.3.0 milestone Mar 16, 2021
flamisz
flamisz approved these changes Mar 16, 2021
View reviewed changes
Copy link
Contributor

@flamisz flamisz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I tested locally. First I didn't get it, how can it happen, but now I see: when we have multiple sites, but the active user has access only for one.

@flamisz flamisz removed the Needs Review PRs that need a code review label Mar 16, 2021
@diosmosis diosmosis merged commit 4778bc5 into 4.x-dev Mar 17, 2021
@diosmosis diosmosis deleted the siteselection branch March 17, 2021 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flamisz flamisz flamisz approved these changes

Assignees
No one assigned
Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Regression Indicates a feature used to work in a certain way but it no longer does even though it should.
Projects
None yet
Milestone
4.3.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sgiehl @flamisz @diosmosis