New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set width for calendar #17348
Set width for calendar #17348
Conversation
Wondering if it might look a bit better if the period options would be placed with a fixed distance to the calendar. |
Yeah, probably. Currently, that's a table, which is not the best practise these days. I will look into it what's the quickest solution. |
I'd actually prefer the original look and also how it was shown in Firefox be totally fine for me if the compare is over two lines (in some ways you could argue it's even better over two lines if there was a bit more gap on top of Maybe the width of the calendar could be made only slightly wider and if it breaks in some languages we wouldn't mind because it would still kind of work. Seems @mattab is not happy with the two lines though so be good to comment @mattab |
Would it be possible to make it look like this? so same as #17348 (comment) but:
|
@mattab problem are also eg translations etc. from a UX point of view the way you want it is btw some confusing because you look from top to bottom and you see various periods listed on the right and you look further down where it then suddenly says previous periods and it's not clear what/how that relates to. I would say to show the |
Agreed, that would be a great improvement to show the |
Yeah, it will work, but only in English. So my next question is what about other languages? Like in German, the word is longer, so won't fit. I can make the fonts smaller so even longer words can fit, only the very long ones will break into 2 lines. |
for visual consistency it's better to preserve the box width, so instead you can do the other solution " long ones will break into 2 lines." 👍 |
37a55f0
to
3c43371
Compare
I tweaked the css a little bit, works well with even German translation, tested it in IE11/Chrome/Firefox. Screen.Recording.2021-03-29.at.6.54.19.PM.mov |
3808c2d
to
406dc88
Compare
👋 @mattab can you please check the latest version of this? There is a short video in my previous comment. Thanks |
Looks good to me @flamisz 👍 Nice improvement |
Description:
fixes #17162
Tested in FF, Chrome and IE11.
Tested with responsive design mode as well.
Review