Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some archive deletion logs. #17347

Merged
merged 1 commit into from Mar 16, 2021
Merged

Add some archive deletion logs. #17347

merged 1 commit into from Mar 16, 2021

Conversation

diosmosis
Copy link
Member

Description:

Couple logs only executed when in core:archive command.

Review

  • Functional review done
  • Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done see checklist
  • Code review done
  • Tests were added if useful/possible
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed

@diosmosis diosmosis added this to the 4.3.0 milestone Mar 16, 2021
@diosmosis diosmosis merged commit 35a4a35 into 4.x-dev Mar 16, 2021
@diosmosis diosmosis deleted the archive-deletion-logs branch March 16, 2021 02:59
@mattab mattab added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label May 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants