@tsteur opened this Issue on March 14th 2021 Member

see https://github.com/matomo-org/matomo/issues/17318#issuecomment-793471155

In #17318 we're discussing about following up automatically when a PR has been waiting for a review for too long. This issue is about automatically following up when we're waiting for the PR author.

We could maybe follow up with (community) PRs automatically if they have been inactive for a while for example when we're waiting for changes for say 2 weeks or more.

After 6 weeks we could close the PR and remind the PR author that we'll reopen the PR again once work continues etc.

so far we have this message for when a PR is more than 1 month old: https://github.com/matomo-org/matomo/wiki/Triage-the-issue-trackers#pull-request-more-than-1-month-old

This logic would ideally also apply to our own PRs but we'd need to have a custom label that we can assign to ignore this logic as sometimes we want to keep a PR open for longer.

I wonder though how we'd know if a PR is inactive for too long? I suppose it would be if there PR was last marked as Review: Changes requested and there hasn't been a commit since then?

@flamisz recommended https://github.com/actions/stale https://github.com/marketplace/actions/close-stale-issues for closing the issues automatically. We'd also want to comment automatically though.

fyi @mattab

@tsteur commented on March 14th 2021 Member
@flamisz commented on March 15th 2021 Contributor

@tsteur the action I recommended can comment and add a label on the pr or issue first, and closing later (can setup how many days of inactivity triggers what). Lots of options.
I added to one of my private repos and set it up for dry run. It means it doesn't add any comment, label, or closing the pr, only we can see in the run log, what would have happened in live mode.

@sgiehl commented on March 15th 2021 Member

For this case we could even use an GitHub App instead of an action. e.g. https://probot.github.io/apps/stale/

@tsteur commented on March 15th 2021 Member

@flamisz great that it could comment first say after 2 weeks and then close after 6 weeks. Does this time start from PR creation? Is there any chance to only start the time measurement for example from the time Needs Review label was added or once the PR is no longer Draft and then the time from the last commit or so?

So far it says had no activity for a specified amount of time but not sure how they define activity. It might work though as well if we just say if nothing happened for say 2 weeks in a PR then leave a comment.

Powered by GitHub Issue Mirror