Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not try to remove webserver config files #17340

Merged
merged 1 commit into from Mar 13, 2021
Merged

Do not try to remove webserver config files #17340

merged 1 commit into from Mar 13, 2021

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Mar 12, 2021

Description:

The files are overwritten if possible nevertheless, so removing them before shouldn't be needed at all.

fixes #17290

Review

  • Functional review done
  • Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done see checklist
  • Code review done
  • Tests were added if useful/possible
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed

@sgiehl
Do not try to remove webserver config files
a8d142f 
they are overwritten if possible nevertheless
@sgiehl sgiehl added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels Mar 12, 2021
@sgiehl sgiehl added this to the 4.3.0 milestone Mar 12, 2021
@diosmosis diosmosis merged commit a5c70b3 into 4.x-dev Mar 13, 2021
@diosmosis diosmosis deleted the htaccessremoval branch March 13, 2021 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
4.3.0
Development

Successfully merging this pull request may close these issues.

Tests slow since 4.2.1
2 participants
@sgiehl @diosmosis