Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update help screen #17338

Merged
merged 2 commits into from Mar 15, 2021
Merged

update help screen #17338

merged 2 commits into from Mar 15, 2021

Conversation

flamisz
Copy link
Contributor

@flamisz flamisz commented Mar 12, 2021 •
edited

Description:

fixes #17108

Review

  • Functional review done
  • Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done see checklist
  • Code review done
  • Tests were added if useful/possible
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed

@flamisz flamisz self-assigned this Mar 12, 2021
@flamisz flamisz added this to the 4.3.0 milestone Mar 12, 2021
@flamisz flamisz added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Mar 12, 2021
@flamisz
Copy link
Contributor Author

flamisz commented Mar 12, 2021

fyi @mattab

@sgiehl
Copy link
Member

sgiehl commented Mar 12, 2021

@flamisz the expected UI file needs to be updated (https://builds-artifacts.matomo.org/matomo-org/matomo/17108-help-screen/45625/FeedbackForm_show.png).
Would be good to merge once this is done.

@flamisz flamisz merged commit 069d2de into 4.x-dev Mar 15, 2021
@flamisz flamisz deleted the 17108-help-screen branch March 15, 2021 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@flamisz flamisz

Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
4.3.0
Development

Successfully merging this pull request may close these issues.

In "Help" screen, show first the section "How can we help?"
2 participants
@flamisz @sgiehl