@flamisz opened this Pull Request on March 12th 2021 Contributor

Description:

fixes #17108

Review

  • [x] Functional review done
  • [x] Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
  • [x] Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • [x] Security review done see checklist
  • [x] Code review done
  • [x] Tests were added if useful/possible
  • [x] Reviewed for breaking changes
  • [x] Developer changelog updated if needed
  • [x] Documentation added if needed
  • [x] Existing documentation updated if needed
@flamisz commented on March 12th 2021 Contributor

fyi @mattab

@sgiehl commented on March 12th 2021 Member

@flamisz the expected UI file needs to be updated (https://builds-artifacts.matomo.org/matomo-org/matomo/17108-help-screen/45625/FeedbackForm_show.png).
Would be good to merge once this is done.

This Pull Request was closed on March 15th 2021
Powered by GitHub Issue Mirror