Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix check for invalid image sizes #17334

Merged
merged 1 commit into from Mar 11, 2021
Merged

Fix check for invalid image sizes #17334

merged 1 commit into from Mar 11, 2021

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Mar 11, 2021

Description:

Seems I've merged #17320 too early. Afterwards some system tests generating image started to fail, as an exception was thrown even though the dimension should be valid.

Debugged a bit through the code, and I think the new condition should prevent any modulo error but still show an image if it is possible.

@flamisz maybe you could have a quick look and merge if it's fine.

Review

  • Functional review done
  • Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done see checklist
  • Code review done
  • Tests were added if useful/possible
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed

@sgiehl sgiehl added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review Regression Indicates a feature used to work in a certain way but it no longer does even though it should. labels Mar 11, 2021
@sgiehl sgiehl added this to the 4.3.0 milestone Mar 11, 2021
@sgiehl sgiehl requested a review from flamisz March 11, 2021 16:07
flamisz
flamisz approved these changes Mar 11, 2021
View reviewed changes
Copy link
Contributor

@flamisz flamisz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix.

I did a quick test and it works fine for me.

@flamisz flamisz removed the Needs Review PRs that need a code review label Mar 11, 2021
@flamisz flamisz merged commit ef21f8e into 4.x-dev Mar 11, 2021
@flamisz flamisz deleted the fiximagegraph branch March 11, 2021 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flamisz flamisz flamisz approved these changes

Assignees
No one assigned
Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Regression Indicates a feature used to work in a certain way but it no longer does even though it should.
Projects
None yet
Milestone
4.3.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sgiehl @flamisz