Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow forcing Archive to not initiate archiving for child archives #17331

Merged
merged 1 commit into from Mar 10, 2021

Conversation

diosmosis
Copy link
Member

Description:

So we can disallow archiving of child archives when generating archives of a higher period. (Not public API)

Review

  • Functional review done
  • Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done see checklist
  • Code review done
  • Tests were added if useful/possible
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed

@diosmosis diosmosis added the Needs Review PRs that need a code review label Mar 10, 2021
@diosmosis diosmosis added this to the 4.3.0 milestone Mar 10, 2021
@diosmosis
Copy link
Member Author

FYI @tsteur

@diosmosis diosmosis merged commit daa245d into 4.x-dev Mar 10, 2021
@diosmosis diosmosis deleted the allow-forcing-fetch-without-archiving branch March 10, 2021 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants