Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add plugin name as comment to SQL query #17327

Closed
Starker3 opened this issue Mar 10, 2021 · 0 comments · Fixed by #17337
Closed

Add plugin name as comment to SQL query #17327

Starker3 opened this issue Mar 10, 2021 · 0 comments · Fixed by #17337
Labels
Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. Help wanted Beginner friendly issues or issues where we'd highly appreciate community's help and involvement.
Milestone
4.3.0

Comments

@Starker3
Copy link
Contributor

Summary

It would be really useful for troubleshooting performance issues on the database server if people knew exactly which plugin/report was triggering.

After discussing with @mattab he suggested that it would quite useful if the plugin name was added as a comment to SQL queries that are sent to the database.
This would make it quite obvious in a lot of situations which plugins are causing higher db load and Matomo administrators can then take direct steps to either disable the plugin or make necessary config changes to improve the performance relating to that plugin.
@Starker3 Starker3 added the Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. label Mar 10, 2021
@tsteur tsteur added this to the Priority Backlog (Help wanted) milestone Mar 10, 2021
@tsteur tsteur added the Help wanted Beginner friendly issues or issues where we'd highly appreciate community's help and involvement. label Mar 10, 2021
@tsteur tsteur mentioned this issue Mar 10, 2021
Closed
@flamisz flamisz mentioned this issue Mar 11, 2021
Merged
10 tasks
@sgiehl sgiehl modified the milestones: 4.5.0, 4.3.0 Apr 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. Help wanted Beginner friendly issues or issues where we'd highly appreciate community's help and involvement.
Projects
None yet
Milestone
4.3.0
Development

Successfully merging a pull request may close this issue.

modify SegmentQueryDecorator so extra comment information can be saved matomo-org/matomo
3 participants
@tsteur @sgiehl @Starker3