Add --skip-cache-clear option to core:update command … #17326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to clear caches when updating on an empty ec2 instance (for example).
sgiehl
reviewed
Mar 10, 2021
| if (self::$skipCacheClearOnUpdate) { | ||
| return; | ||
| } | ||
|
|
There was a problem hiding this comment.
Shouldn't we reload the plugin information nevertheless? Wondering if it might cause weird issues when a plugin is updated, but the information isn't reloaded.
There was a problem hiding this comment.
skipping this change as discussed on slack
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
…so we don't have to clear caches when updating on an empty ec2 instance (for example). This PR uses a static member var to stop cache clears for the entire process since it is done once in the command, once in the CoreUpdater, and possibly multiple times in the plugin manager (if plugins are activated/deactivated for instance).
FYI @tsteur
Review