@diosmosis opened this Pull Request on March 10th 2021 Member

Description:

…so we don't have to clear caches when updating on an empty ec2 instance (for example). This PR uses a static member var to stop cache clears for the entire process since it is done once in the command, once in the CoreUpdater, and possibly multiple times in the plugin manager (if plugins are activated/deactivated for instance).

FYI @tsteur

Review

  • [ ] Functional review done
  • [ ] Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
  • [ ] Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • [ ] Security review done see checklist
  • [ ] Code review done
  • [ ] Tests were added if useful/possible
  • [ ] Reviewed for breaking changes
  • [ ] Developer changelog updated if needed
  • [ ] Documentation added if needed
  • [ ] Existing documentation updated if needed
This Pull Request was closed on March 10th 2021
Powered by GitHub Issue Mirror