Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow configuring segments to not be rearchived when rearchiving reports in the past. #17325

Merged
merged 1 commit into from Mar 10, 2021

Conversation

diosmosis
Copy link
Member

Description:

FYI @tsteur

Adds new INI config option rearchive_reports_in_past_exclude_segments to disallow archiving segments when rearchiving in past. Should be fine for things like plugin activations and entity creation, but I can see one issue w/ updating an entity. If there is already segment data for the old entity, then that will be displayed as if it is new. Perhaps this should also be paired w/ a new feature that doesn't use archive data if it is older than the entity last update time? This would require being able to set the last update time in, eg, a Report or ViewDataTable class and checking this against the ts_archived. I imagine there would be support requests if we just show the old data.

Also includes a small bug fix (processed $idSites value not being used in applyScheduledRearchiving).

Review

  • Functional review done
  • Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done see checklist
  • Code review done
  • Tests were added if useful/possible
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed

@diosmosis diosmosis added the Needs Review PRs that need a code review label Mar 10, 2021
@diosmosis diosmosis added this to the 4.3.0 milestone Mar 10, 2021
@diosmosis diosmosis merged commit e060916 into 4.x-dev Mar 10, 2021
@diosmosis diosmosis deleted the rearchive_in_past_exclude_segments branch March 10, 2021 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants