Allow configuring segments to not be rearchived when rearchiving reports in the past. #17325
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
FYI @tsteur
Adds new INI config option
rearchive_reports_in_past_exclude_segments
to disallow archiving segments when rearchiving in past. Should be fine for things like plugin activations and entity creation, but I can see one issue w/ updating an entity. If there is already segment data for the old entity, then that will be displayed as if it is new. Perhaps this should also be paired w/ a new feature that doesn't use archive data if it is older than the entity last update time? This would require being able to set the last update time in, eg, a Report or ViewDataTable class and checking this against thets_archived
. I imagine there would be support requests if we just show the old data.Also includes a small bug fix (processed $idSites value not being used in applyScheduledRearchiving).
Review