@diosmosis opened this Pull Request on March 10th 2021 Member

Description:

FYI @tsteur

Adds new INI config option rearchive_reports_in_past_exclude_segments to disallow archiving segments when rearchiving in past. Should be fine for things like plugin activations and entity creation, but I can see one issue w/ updating an entity. If there is already segment data for the old entity, then that will be displayed as if it is new. Perhaps this should also be paired w/ a new feature that doesn't use archive data if it is older than the entity last update time? This would require being able to set the last update time in, eg, a Report or ViewDataTable class and checking this against the ts_archived. I imagine there would be support requests if we just show the old data.

Also includes a small bug fix (processed $idSites value not being used in applyScheduledRearchiving).

Review

  • [ ] Functional review done
  • [ ] Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
  • [ ] Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • [ ] Security review done see checklist
  • [ ] Code review done
  • [ ] Tests were added if useful/possible
  • [ ] Reviewed for breaking changes
  • [ ] Developer changelog updated if needed
  • [ ] Documentation added if needed
  • [ ] Existing documentation updated if needed
This Pull Request was closed on March 10th 2021
Powered by GitHub Issue Mirror