Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix failing ui tests #17324

Merged
merged 1 commit into from Mar 10, 2021
Merged

fix failing ui tests #17324

merged 1 commit into from Mar 10, 2021

Conversation

flamisz
Copy link
Contributor

@flamisz flamisz commented Mar 10, 2021

Description:

I try to fix the failing UI tests with this PR.

Review

  • Functional review done
  • Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done see checklist
  • Code review done
  • Tests were added if useful/possible
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed

@flamisz flamisz self-assigned this Mar 10, 2021
@flamisz flamisz added Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. labels Mar 10, 2021
@flamisz flamisz marked this pull request as ready for review March 10, 2021 03:21
@flamisz
Copy link
Contributor Author

flamisz commented Mar 10, 2021

It fixed one test. The other still failing. Do we want to merge it?

@diosmosis
Copy link
Member

👍 looks good @flamisz I don't think the other one can be fixed w/o using something like

matomo/plugins/UsersManager/tests/UI/UsersManager_spec.js

Line 215 in 8e344bd

comparisonThreshold: 0.0005,

@diosmosis diosmosis merged commit 28ce0a9 into 4.x-dev Mar 10, 2021
@diosmosis diosmosis deleted the fix-ui-tests branch March 10, 2021 04:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@flamisz flamisz

Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@flamisz @diosmosis