Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return HTTP Status 404 if Matomo is not yet installed #17322

Merged
merged 1 commit into from Mar 10, 2021
Merged

Return HTTP Status 404 if Matomo is not yet installed #17322

merged 1 commit into from Mar 10, 2021

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Mar 9, 2021

Description:

as per title

Review

  • Functional review done
  • Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done see checklist
  • Code review done
  • Tests were added if useful/possible
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed

@sgiehl sgiehl added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels Mar 9, 2021
@sgiehl sgiehl added this to the 4.3.0 milestone Mar 9, 2021
@sgiehl sgiehl requested a review from tsteur March 9, 2021 09:05
flamisz
flamisz approved these changes Mar 9, 2021
View reviewed changes
Copy link
Contributor

@flamisz flamisz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@flamisz flamisz removed the Needs Review PRs that need a code review label Mar 9, 2021
@sgiehl sgiehl merged commit a8da263 into 4.x-dev Mar 10, 2021
@sgiehl sgiehl deleted the notinstalledresponsecode branch March 10, 2021 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsteur tsteur tsteur approved these changes

@flamisz flamisz flamisz approved these changes

Assignees
No one assigned
Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
4.3.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sgiehl @tsteur @flamisz