@diosmosis opened this Pull Request on March 9th 2021 Member

Description:

There can potentially be a lot of invalidating of the tracker cache since we call ArchiveInvalidator functions one after the other. This PR introduces a utility function that collects all tracker cache clears and calls them just once after a callback finishes executing.

Review

  • [ ] Functional review done
  • [ ] Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
  • [ ] Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • [ ] Security review done see checklist
  • [ ] Code review done
  • [ ] Tests were added if useful/possible
  • [ ] Reviewed for breaking changes
  • [ ] Developer changelog updated if needed
  • [ ] Documentation added if needed
  • [ ] Existing documentation updated if needed
@tsteur commented on March 9th 2021 Member

It's not public API so no need to mention it 👍

@tsteur commented on March 11th 2021 Member

fyi @diosmosis 2 tests still failing but maybe they are not due to this PR? https://travis-ci.com/github/matomo-org/matomo/jobs/489891666#L806

This Pull Request was closed on March 12th 2021
Powered by GitHub Issue Mirror