Throw invalid dimension exception during rendering graph with wrong height/width values #17320
Conversation
|
Wondering if it might make more sense to define lower limits for height & weight and automatically set those parameters to the lower limit if they are smaller. That way we could avoid any exception at all. |
Hey @sgiehl, me and @tsteur were talking about that, and I could calculate that, but if the user wants a lower number, and the graph will be higher, maybe she/he will think it is a bug. Hard to tell which is the better solution, but probably it is something that happens very rarely. |
|
@sgiehl the thought was that if we automatically change a height or width then it will look like a bug and we're getting bug reports and emails about it vs this way it's clear what the problem is and they can change the parameters to a higher number. |
|
Thought we would have it that way in other places, but wasn't able to find one right now. But it's also fine this way. |
flamisz
added
Needs Review
Description:
fixes #17092
The package we use for rendering graphs has a bug. To avoid run into that bug, we can check the values we send to the package and if the values would cause the modulo zero error we throw an exception instead.
Our plugin throws the exceptions as an image by default, but for this error it's not that useful, because usually it happens when the height value is too small, so the user wouldn't be able to read the error message.
For this specific exception I used the default way.
Review