@tsteur opened this Issue on March 8th 2021 Member

Hi there,

currently we have a few PRs that are waiting for reviews for > 10 days like https://github.com/matomo-org/matomo/pull/17264 and https://github.com/matomo-org/matomo/pull/17266

I wonder if we could have a github action or some other reminder that pings all of us if there was an issue with "needs review" and there was no comment or review for 7 days? Or maybe even just 5 days? Of course it's not always that trivial since we might be waiting for a change from the author etc but maybe also https://github.com/matomo-org/matomo/issues/17317 would simplify the logic a bit.

We could maybe start with a simple reminder once there has been no comment from us for say 3 or 5 business days (or 5-7 regular days) and then see how this works over time and could then make adjustments to it if needed. The added comment could say something like This issue is in "needs review" but there has been no comment for X days. <a class='mention' href='https://github.com/tsteur'>@tsteur</a> ... we would then ping all of us maybe.

Or maybe the issue was simply that there was no milestone assigned in which case we'd want to make sure a Needs Review PR always also has a milestone?

Or are there better/other ways maybe? Any thoughts appreciated @diosmosis @Findus23 @flamisz @sgiehl @mattab

Maybe also #17317 would make things better and a new github action wouldn't be needed. Not sure it's even possible to solve with a github action.

In https://github.com/matomo-org/matomo/issues/17344 there's also an issue for automatically following up when we're waiting for a PR author for too long.

@diosmosis commented on March 8th 2021 Member

Lately the problem I've had is just not having time, w/ deploys and L3 issues. That's mostly died down though, so I should be able to get back to reviewing regularly. It could be prioritized higher I suppose (ie, pr reviews before investigating L3 issues).

@sgiehl commented on March 8th 2021 Member

@tsteur such stuff should be possible with github actions for sure. Maybe there are already some matching actions like: https://github.com/marketplace/actions/pull-request-reviewer-reminder-action

@flamisz commented on March 9th 2021 Contributor
@tsteur commented on March 14th 2021 Member

@sgiehl regarding https://github.com/marketplace/actions/pull-request-reviewer-reminder-action

do you know from when they start the timer to measure the turnaround time? Maybe it won't work for our case regarding the labels etc?

@flamisz for closing issues automatically created https://github.com/matomo-org/matomo/issues/17344

@sgiehl commented on March 15th 2021 Member

@tsteur yes, that won't work depending on labels. guess the time is calculated based on the creation time.
Maybe there are some other actions that would be able to handle what we need. Guess someone would need to look a bit deeper into it. I actually only did a quick search yet. If there isn't anything we could also make a custom action to handle that.

@tsteur commented on March 15th 2021 Member

I think just like in #17344 we could potentially use https://github.com/marketplace/actions/close-stale-issues as well and only apply the rule when only-labels = Needs Review and there has been no activity for say 7 days.

This Issue was closed on June 16th 2021
Powered by GitHub Issue Mirror