Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixing icons alignment #17313

Merged
merged 1 commit into from Mar 14, 2021
Merged

fixing icons alignment #17313

merged 1 commit into from Mar 14, 2021

Conversation

flamisz
Copy link
Contributor

@flamisz flamisz commented Mar 8, 2021

Description:

fixes #16510

Review

  • Functional review done
  • Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done see checklist
  • Code review done
  • Tests were added if useful/possible
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed

@flamisz flamisz self-assigned this Mar 8, 2021
@flamisz flamisz added Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. and removed Needs Review PRs that need a code review labels Mar 8, 2021
@tsteur
Copy link
Member

tsteur commented Mar 8, 2021

fyi checked on the server, for some reason no screenshots are uploaded even though it looks in the travis output like it works correctly

@flamisz flamisz added this to the 3.14.2 milestone Mar 9, 2021
@diosmosis diosmosis merged commit ef814c8 into 3.x-dev Mar 14, 2021
@diosmosis diosmosis deleted the 16510-icons-alignment-matomo3 branch March 14, 2021 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@flamisz flamisz

Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
3.14.2
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@flamisz @tsteur @diosmosis