Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new wordtruncate twig filter and use in datatable headers #17303

Closed
wants to merge 3 commits into from

Conversation

flamisz
Copy link
Contributor

@flamisz flamisz commented Mar 4, 2021

Description:

fixes #17242

When we have very long words in the datatable header rows, it can cause wide columns, so the user has to scroll horizontally to see every data.
With a new twig filter, we can truncate the header string word by word. The whole word and more detailed explanation still viewable by hovering the mouse on the text.

Review

  • Functional review done
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done see checklist
  • Code review done
  • Tests were added if useful/possible
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed

@flamisz flamisz self-assigned this Mar 4, 2021
@flamisz flamisz added Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. labels Mar 4, 2021
@flamisz flamisz removed Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. labels Mar 7, 2021
@flamisz
Copy link
Contributor Author

flamisz commented Mar 7, 2021

Closing for now, as we changing the language file instead.

@flamisz flamisz closed this Mar 7, 2021
@sgiehl sgiehl deleted the 17242-datatable-header-wordwrap branch April 5, 2023 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Performance report table not displayed properly
1 participant